Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cloudflare Setting: Optionally fetch CF IPs on container boot. #2878

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pglombardo
Copy link
Owner

@pglombardo pglombardo commented Dec 12, 2024

Description

With recent releases only local proxies are trusted by default. There is a setting that allows you to add IPs to this list but in cases where Cloudflare has a long list or often change IPs this can be troublesome.

This PR adds PWP__CLOUDFLARE_PROXY=false and a cloudflare_proxy: false in your settings.yml. Set one of these to true to enable fetching of CloudFlare IPs on container boot.

See #2799 for the discussion.

Related Issue

#2799

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@pglombardo pglombardo merged commit 35a7634 into master Dec 12, 2024
6 checks passed
@pglombardo pglombardo deleted the fix-2799 branch December 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant